fix: make request URI building idempotent#798
Open
overcat wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Horizon request builder URL construction to be idempotent, preventing path segments from being duplicated when buildUri() (and therefore execute()) is called multiple times on the same builder instance.
Changes:
- Update
RequestBuilder#buildUri()to avoid duplicating path segments across repeated invocations. - Add a regression test ensuring repeated
buildUri()calls produce the same URI. - Document the fix in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/java/org/stellar/sdk/requests/AccountsRequestBuilderTest.java | Adds a regression test asserting repeated buildUri() calls don’t change the generated URL. |
| src/main/java/org/stellar/sdk/requests/RequestBuilder.java | Changes URI construction logic to rebuild from the server base each time, aiming for idempotency. |
| CHANGELOG.md | Notes the idempotent URL generation fix under “Pending”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overcat
force-pushed
the
fix/request-builder-build-uri-idempotent
branch
2 times, most recently
from
f80baf7 to
54446e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
============================================
+ Coverage 82.63% 82.67% +0.03%
- Complexity 1615 1617 +2
============================================
Files 232 232
Lines 5938 5940 +2
Branches 657 658 +1
============================================
+ Hits 4907 4911 +4
+ Misses 659 657 -2
Partials 372 372
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.